Merged
Conversation
* Define a new generic scanner.Result structure * Consume channels in the scanner.Scanner context
As this annoying logging has been removed in Freeaqingme/go-clamd@1b4a274e
vjt
force-pushed
the
remove-vendored-code
branch
from
388e74a to
f20e9ca
Compare
Contributor
Author
|
@atzoum wdyt? :-) |
Contributor
Author
|
@jblackman your feedback is also very welcome |
Contributor
|
Looks good. The @dutchcoders guys move pretty slowly, but keep an eye out for them merging in the changes from the @Freeaqingme fork, assuming he ever bothers with a merge request. |
Contributor
Author
|
Thanks both! Merging and cutting a v0.6.0 release. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes #1 by moving to from @dutchcoders's go-clamd to @Freeaqingme's fork, that removes annoying logging and adds more structured responses.